Skip to content

pkp/pkp-lib#12506 Update weblate locale mapping for TinyMCE locales #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bozana wants to merge 1 commit into
base: stable-3_5_0
Choose a base branch
from
+5 −8
Open

pkp/pkp-lib#12506 Update weblate locale mapping for TinyMCE locales #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions TinyMCEPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public function registerJS(string $hookName, array $args): bool
// Load the script data used by the JS library
$data = [];
$localeKey = $this->getTinyMCELocale(Locale::getLocale());
if ($localeKey && $localeKey !== 'en_US') {
if ($localeKey) {
$data['tinymceParams'] = [
'language' => $localeKey,
'language_url' => $request->getBaseUrl() . '/plugins/generic/tinymce/langs/' . $localeKey . '.js',
Expand Down Expand Up @@ -140,11 +140,9 @@ public function getTinyMCELocale(string $locale): ?string
$prefix = $this->getPluginPath() . '/langs/';
$suffix = '.js';
$preferences = [
'de' => 'de_DE',
'en' => 'en_US',
'es' => 'es_ES',
'fr' => 'fr_FR',
'pt' => 'pt_PT',
'zh_Hans' => 'zh_CN',
'zh_Hant' => 'zh_TW',
];

$language = \Locale::getPrimaryLanguage($locale);
Expand All @@ -155,14 +153,13 @@ public function getTinyMCELocale(string $locale): ?string
if (in_array("{$prefix}{$locale}{$suffix}", $availableLocaleFiles)) {
return $locale;
}
// 2. Look in the preference list for a preferred fallback. -- No preferences defined so no need to do this step
// 2. Look in the preference list for a preferred fallback.
if ($preference = $preferences[$locale] ?? false) {
return $preference;
}
// 3. Find the first match by language.
foreach ($availableLocaleFiles as $filename) {
if (strpos($filename, "{$prefix}{$language}{$prefix}") === 0 || strpos($filename, "{$prefix}{$language}_") === 0) {
$substring = substr($filename, strlen($prefix), -strlen($suffix));
if (strpos($filename, "{$prefix}{$language}{$suffix}") === 0 || strpos($filename, "{$prefix}{$language}_") === 0) {
return substr($filename, strlen($prefix), -strlen($suffix));
}
}
Expand Down