Skip to content

feat: add default surname #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
forderation wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add default surname #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b637798
feat: add default surname
forderation Feb 19, 2022
84aceb3
Update ArticleCrossrefXmlFilter.inc.php
forderation Feb 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions filter/ArticleCrossrefXmlFilter.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,10 @@ public function createJournalArticleNode($doc, $submission)
// Check if both givenName and familyName is set for the submission language.
if (!empty($familyNames[$locale]) && !empty($givenNames[$locale])) {
$personNameNode->setAttribute('language', LocaleConversion::getIso1FromLocale($locale));
$personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars(ucfirst($givenNames[$locale]), ENT_COMPAT, 'UTF-8')));
$personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars(ucfirst($familyNames[$locale]), ENT_COMPAT, 'UTF-8')));
$givenName = $givenNames[$locale];
$familyName = $this->getDefaultSurname($givenName, $familyNames[$locale]);
$personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars(ucfirst($givenName), ENT_COMPAT, 'UTF-8')));
$personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars(ucfirst($familyName), ENT_COMPAT, 'UTF-8')));
$hasAltName = false;

if ($author->getData('orcid')) {
Expand All @@ -162,7 +164,7 @@ public function createJournalArticleNode($doc, $submission)

$nameNode = $doc->createElementNS($deployment->getNamespace(), 'name');
$nameNode->setAttribute('language', LocaleConversion::getIso1FromLocale($otherLocal));

$familyName = $this->getDefaultSurname($givenName, $familyName);
$nameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars(ucfirst($familyName), ENT_COMPAT, 'UTF-8')));
if (isset($givenNames[$otherLocal]) && !empty($givenNames[$otherLocal])) {
$nameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars(ucfirst($givenNames[$otherLocal]), ENT_COMPAT, 'UTF-8')));
Expand Down Expand Up @@ -293,6 +295,30 @@ public function createJournalArticleNode($doc, $submission)
return $journalArticleNode;
}

/**
* get default surname within given name, and family name
* will be use last given name if family name is empty
*
* @param string $givenName
* @param string $familyName
*
* @return string
*/
function getDefaultSurname($givenName, $familyName)
{
$splitGivenName = explode(" ", $givenName);
$lenSplitGivenName = count($splitGivenName);
if ($lenSplitGivenName != 0) {
$givenName = $splitGivenName[$lenSplitGivenName - 1];
}
$familyName = str_replace(" ", "", $familyName);
// if empty string
if ($familyName == null || strlen($familyName) == 0) {
$familyName = $givenName;
}
return $familyName;
}

/**
* Append the collection node 'collection property="crawler-based"' to the doi data node.
*
Expand Down