Fix indent bug for tables without headers (issue piotrmurach/tty-table/issues/45)#44
Open
rogermarlow wants to merge 8 commits intopiotrmurach:masterfrom
Open
Conversation
houndci-bot
reviewed
Mar 14, 2024
houndci-bot
reviewed
Mar 14, 2024
| it "indents top border correctly" do | ||
| table = TTY::Table.new | ||
| table << ["a1","a2","a3"] | ||
| table << ["b1","b2","b3"] |
There was a problem hiding this comment.
Style/WordArray: Use %w or %W for an array of words.
Layout/SpaceAfterComma: Space missing after comma.
| RSpec.describe TTY::Table::Renderer::ASCII, 'indentation without headers' do | ||
| it "indents top border correctly" do | ||
| table = TTY::Table.new | ||
| table << ["a1","a2","a3"] |
There was a problem hiding this comment.
Style/WordArray: Use %w or %W for an array of words.
Layout/SpaceAfterComma: Space missing after comma.
| end | ||
| end | ||
|
|
||
| RSpec.describe TTY::Table::Renderer::ASCII, 'indentation without headers' do |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Author
|
This has failed at appveyor because of a github connectivity issue rather than a test failure. I don't know how to re-run the job so I will push a trivial change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
There is a bug rendering tables without headers with an indent. The top border is not indented.
Why are we doing this?
Bug fix.
Benefits
Bug fix.
Drawbacks
None.
Here is come code that demonstrates the problem:
Requirements
masterbranch?