Skip to content

Fix bundle-only data channel startup#3447

Merged
JoTurk merged 2 commits into
pion:mainfrom
zshang-oai:codex/fix-bundle-only-data-channel
Jun 10, 2026
Merged

Fix bundle-only data channel startup#3447
JoTurk merged 2 commits into
pion:mainfrom
zshang-oai:codex/fix-bundle-only-data-channel

Conversation

@zshang-oai

Copy link
Copy Markdown
Contributor

Pion currently treats every zero-port application m= section as rejected. This violates RFC 8843, Section 6, which permits a bundled m= section to use port zero with a=bundle-only.

Start SCTP when the application section has either a nonzero port or a=bundle-only. Zero-port sections without a=bundle-only remain rejected.

Comment thread datachannel_test.go Outdated
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.48%. Comparing base (6a5d2f8) to head (79bf622).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3447      +/-   ##
==========================================
- Coverage   85.54%   85.48%   -0.06%     
==========================================
  Files          81       81              
  Lines        9856     9857       +1     
==========================================
- Hits         8431     8426       -5     
- Misses       1005     1011       +6     
  Partials      420      420              
Flag Coverage Δ
go 85.48% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zshang-oai zshang-oai requested a review from JoTurk June 10, 2026 19:49
@zshang-oai zshang-oai force-pushed the codex/fix-bundle-only-data-channel branch from d9aeebd to 79bf622 Compare June 10, 2026 19:50
@zshang-oai zshang-oai requested a review from sirzooro June 10, 2026 19:55
@zshang-oai zshang-oai marked this pull request as ready for review June 10, 2026 19:55

@JoTurk JoTurk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much.

@JoTurk JoTurk merged commit ec1dd73 into pion:main Jun 10, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants