Skip to content

SNAP: fix renegotiation bug#3443

Merged
fippo merged 1 commit into
mainfrom
snap-renego
Jun 3, 2026
Merged

SNAP: fix renegotiation bug#3443
fippo merged 1 commit into
mainfrom
snap-renego

Conversation

@fippo

@fippo fippo commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

which did not carry sctp-init in subsequent offers when the initial offer was media-only

Description

Reference issue

Fixes #...

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.51%. Comparing base (898d90d) to head (80c78bc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3443      +/-   ##
==========================================
- Coverage   85.52%   85.51%   -0.02%     
==========================================
  Files          81       81              
  Lines        9854     9856       +2     
==========================================
  Hits         8428     8428              
- Misses       1007     1009       +2     
  Partials      419      419              
Flag Coverage Δ
go 85.51% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

which did not carry sctp-init in subsequent offers when
the initial offer was media-only
@fippo fippo changed the title snap: fix renegotiation bug SNAP: fix renegotiation bug Jun 3, 2026
@fippo fippo merged commit bb1c684 into main Jun 3, 2026
23 checks passed
@fippo fippo deleted the snap-renego branch June 3, 2026 18:26
alinz pushed a commit to alinz/webrtc that referenced this pull request Jun 5, 2026
which did not carry sctp-init in subsequent offers when the initial
offer was media-only

(ref pion#3335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants