Skip to content

Add FEC to SDP parsing#242

Open
bfrolikov wants to merge 2 commits intopion:masterfrom
bfrolikov:add-fec-to-unmarshal
Open

Add FEC to SDP parsing#242
bfrolikov wants to merge 2 commits intopion:masterfrom
bfrolikov:add-fec-to-unmarshal

Conversation

@bfrolikov
Copy link

Description

Add FEC to protos currently registered with IANA list

Reference issue

Fixes #241

Copy link
Member

@JoTurk JoTurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@bfrolikov
Copy link
Author

bfrolikov commented Feb 2, 2026

@JoTurk could you please approve the workflows when you have the time?
UPD: Thanks!

@philipch07
Copy link
Contributor

@bfrolikov I have just approved the workflows

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.43%. Comparing base (ac4d006) to head (1a3a691).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          12       12           
  Lines        1404     1405    +1     
=======================================
+ Hits         1368     1369    +1     
  Misses         19       19           
  Partials       17       17           
Flag Coverage Δ
go 97.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@philipch07
Copy link
Contributor

Seems good to merge! @bfrolikov

@JoTurk
Copy link
Member

JoTurk commented Feb 3, 2026

Thank you, I'm going to merge this tomorrow and few other changes, and we'll issue a tag for pion/sdp. I'll leave this open so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Allow FEC in SDP parsing

3 participants