UDPMuxSink for UDPMux allows to inspect packets before being dropped#746
UDPMuxSink for UDPMux allows to inspect packets before being dropped#746astroza wants to merge 1 commit intopion:masterfrom
Conversation
nils-ohlmeier
left a comment
There was a problem hiding this comment.
Looks good to me.
But someone else should probably review this as well.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
==========================================
- Coverage 78.69% 78.50% -0.20%
==========================================
Files 41 41
Lines 4769 4773 +4
==========================================
- Hits 3753 3747 -6
- Misses 783 790 +7
- Partials 233 236 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@nils-ohlmeier You can merge anything without me! As long as it passes the tests I don't care. Nothing worse then waiting on a slow maintainer :) @astorza that's really cool you were able to build a distributed version! Would you mind writing a test for this? Just assert that if set it really does get fired. thank you so much for the contribution |
Description
This is one of the features that helped us to build a distributed version of Pion.
Inspecting UDPMux discarded packets makes it possible to evaluate and restore a PeerConnection if needed