Skip to content

Conversation

@YangKeao
Copy link
Member

@YangKeao YangKeao commented Jan 8, 2026

What problem does this PR solve?

Issue Number: close #1056

Problem Summary:

What is changed and how it works:

Implement a basic support for audit log extension.

The current implementation (based on current extension format) has the following known issues:

  1. All parameters are parsed as string.
  2. Empty string parameters cannot be parsed correctly.
  3. Only end time is stored in the extension format.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 8, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from djshow832 and xhebox January 8, 2026 14:24
@ti-chi-bot ti-chi-bot bot added the size/XXL label Jan 8, 2026
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 75.28090% with 66 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@14d5243). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/cmd/audit_log_extension.go 80.61% 32 Missing and 12 partials ⚠️
pkg/sqlreplay/replay/replay.go 20.00% 9 Missing and 3 partials ⚠️
pkg/sqlreplay/cmd/cmd.go 12.50% 7 Missing ⚠️
pkg/sqlreplay/store/rotate.go 75.00% 1 Missing and 1 partial ⚠️
cmd/replayer/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1057   +/-   ##
=======================================
  Coverage        ?   67.73%           
=======================================
  Files           ?      141           
  Lines           ?    14711           
  Branches        ?        0           
=======================================
  Hits            ?     9965           
  Misses          ?     4066           
  Partials        ?      680           
Flag Coverage Δ
unit 67.73% <75.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support audit log extension format for replayer

2 participants