Conversation
|
Ping. |
|
EEK! Sorry, missed this completely, will look ASAP. |
|
No problem! I appreciate it. |
|
Thanks for the PR! Looks like I've also had pagination code lying around uncommitted for awhile. Just pushed that up if you're interested in taking a look: https://github.com/pifantastic/node-sentry-api/tree/pagination I like your change, but I'm worried about automatically loading all pages, as it could be potentially large. For example, I have projects that receive tens of thousands of events an hour. My solution was to return a cursor for each request, so the caller could decide to make subsequent requests if they need to. I think a combination of our approaches might be desirable? |
|
Or maybe we just add a |
|
Note that this repo is being forked to https://github.com/taskcluster/node-sentry-api. If you'd like to see this functionality merged, we'll be happy to consider a PR, but my guess is that this has bitrotted in the last four years.. |
Implement api pagination. The semantics are:
Client.requestwill be called once the merged resultBecause this is potentially a breaking change, bump the version to 0.1.0.
Also change
host.comtotest.com, per rfc2606: reserved top level DNS namesFixes #1