fix: consolidate winget and homebrew into release.yml#30
Merged
Conversation
…B_TOKEN event block GitHub Actions does not fire 'release: published' events triggered by GITHUB_TOKEN, so winget-releaser.yml and homebrew-releaser.yml never ran. Fix: move both as jobs (winget, homebrew) directly inside release.yml where the tag is already known via needs.check.outputs. They run after the release job, removing the need for event chaining entirely. - Delete winget-releaser.yml and homebrew-releaser.yml - Add winget and homebrew jobs to release.yml with needs: [check, release] - Update smoke-test.yml workflow_run trigger from 'Homebrew Release' to 'Release' - Update RELEASING.md to reflect consolidated workflow Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
winget-releaser.ymlandhomebrew-releaser.ymlwere triggered byon: release: types: [published]. GitHub Actions does not fire thereleaseevent when the release is created byGITHUB_TOKEN(the default token used bysoftprops/action-gh-release). So both workflows never ran after the v1.2.3 release.Fix
Move winget and homebrew as jobs directly inside
release.yml. They already have the version/tag available vianeeds.check.outputs, so no event chaining is needed.wingetjob: runs onwindows-latestafterrelease, callsvedantmgoyal9/winget-releaserwith explicitrelease-taghomebrewjob: runs onubuntu-latestafterrelease, copies formula + stamps real SHA256s into the tapsmoke-test.yml: updatedworkflow_runtrigger from"Homebrew Release"to"Release"(since the separate workflow is gone)winget-releaser.ymlandhomebrew-releaser.ymldeletedTesting
After merging, re-trigger the release for v1.2.3 via Actions → Release → Run workflow to verify winget and homebrew jobs run and succeed.
🤖 Generated with Claude Code