ScrollSyncManager Perf #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is generally prep work for virtualization because we now potentially have noisy dom updates and it's better to not thrash stuff if we don't need too
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR introduces performance optimizations to the ScrollSyncManager to reduce unnecessary DOM operations, preparing the codebase for future virtualization work. The changes ensure scroll synchronization is only active when needed and avoid redundant event listener manipulation.
Changes:
- Added an
enabledflag to track ScrollSyncManager state and skip unnecessary cleanup operations - Optimized event listener management to only add/remove listeners when DOM element references actually change
- Made scroll synchronization conditional on
diffStylebeing 'split', since unified diffs don't require scroll syncing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/diffs/src/managers/ScrollSyncManager.ts | Added enabled flag for state tracking, optimized event listener setup to check for element reference changes, added early return in cleanup when not enabled |
| packages/diffs/src/components/FileDiff.ts | Conditionally setup/cleanup ScrollSyncManager based on whether diffStyle is 'split', ensuring the manager is only active when needed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly some prep work for virtualization to reduce dom work if we can