Skip to content

Live demo on theme, add docs #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mdo merged 17 commits into from
Jan 16, 2026
Merged

Live demo on theme, add docs #267

mdo merged 17 commits into from
Jan 16, 2026

Conversation

@mdo
Copy link
Contributor

@mdo mdo commented Jan 10, 2026

Big WIP, needs a lot of work on the the docs most of all.

@vercel
Copy link

vercel bot commented Jan 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
pierrejs-diff-demo Ready Ready Preview Jan 16, 2026 5:47pm
pierrejs-docs Ready Ready Preview Jan 16, 2026 5:47pm
pierrejs-solid-diff-demo Ready Ready Preview Jan 16, 2026 5:47pm

Request Review

@mdo mdo force-pushed the mdo/theme-page-live branch from f87003a to 18ed1b2 Compare January 13, 2026 23:58
@mdo mdo marked this pull request as ready for review January 14, 2026 18:17
@mdo mdo requested a review from amadeus January 14, 2026 18:17
@amadeus
Copy link
Member

amadeus commented Jan 14, 2026

The page looks really dope, the big question i have is around here's our theme vs here's how to build a custom theme. I worry the discoverability of the custom theme-ing stuff will be tricky

@mdo mdo force-pushed the mdo/theme-page-live branch from 49db12e to c10c3e6 Compare January 15, 2026 20:54
amadeus
amadeus reviewed Jan 15, 2026
View reviewed changes
Copy link
Member

@amadeus amadeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall changes look good to me. Some questions on VSCode spelling but i might just be dumb.

Is it intentional that we are adding 2 more themes to the diffs project? It will make the bundle bigger, so wondering if it's worth the tradeoff?

Also I think I'm still kinda on my bullshit from my earlier comment -- I'm a bit worried the whole docs stuff for theming may not be very discoverable here? Maybe I am overthinking it tho.

@mdo
Copy link
Contributor Author

mdo commented Jan 16, 2026

Pushed an update to add a small theme section to main docs. I imagine that plus main nav link ensures folks will find the relevant docs here.

@mdo mdo merged commit 4464a6d into main Jan 16, 2026
9 checks passed
@mdo mdo deleted the mdo/theme-page-live branch January 16, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amadeus amadeus amadeus left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdo @amadeus