Skip to content

Conversation

@LukeWCS
Copy link
Contributor

@LukeWCS LukeWCS commented May 4, 2025

Fixes #122

@iMattPro
Copy link
Member

iMattPro commented May 4, 2025

What happens if you add - php: '8.4' to the test.yml too, to see how EPVs tests go here in 8.4?

@LukeWCS
Copy link
Contributor Author

LukeWCS commented May 4, 2025

What happens if you add - php: '8.4' to the test.yml too, to see how EPVs tests go here in 8.4?

I haven't tested this because I use phpBB Ext Check. This means I'm essentially working with a standalone installation of EPV.

The most I could do is test it with my test repo and set up the phpBB GH Actions framework there. But even if no DEPRECATED messages appear there, that doesn't help me because I need EPV for phpBB Ext Check.

@iMattPro
Copy link
Member

iMattPro commented May 4, 2025

I meant just set it here as part of this PR and let's see if they pass too. If not, remove it.

@LukeWCS
Copy link
Contributor Author

LukeWCS commented May 4, 2025

Ah, I think I understand now. FYI: I have little knowledge of GitHub and none at all of GH Actions or Unit Tests. ^^

Testing...

@iMattPro iMattPro merged commit 1795f47 into phpbb:master May 4, 2025
8 of 9 checks passed
@LukeWCS LukeWCS deleted the fix-122 branch May 10, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEPRECATED messages under PHP 8.4 regarding implicitly nullable

2 participants