Skip to content

ci: deploy docs when they change#2234

Open
dunglas wants to merge 1 commit intomainfrom
ci/deploy-docs
Open

ci: deploy docs when they change#2234
dunglas wants to merge 1 commit intomainfrom
ci/deploy-docs

Conversation

@dunglas
Copy link
Member

@dunglas dunglas commented Mar 3, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 3, 2026 19:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the GitHub Actions workflow metadata for the Docker image build pipeline.

Changes:

  • Renames the workflow display name from Build Docker images to Build Docker Images.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexandre-daubois
Copy link
Member

Should the PR title be updated?

@dunglas
Copy link
Member Author

dunglas commented Mar 4, 2026

Oops, missing git add (fixed)

@php php deleted a comment from Copilot AI Mar 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

paths:
- "docs/**"
- "README.md"
- "CONTRIBUTING.md"
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow is missing a concurrency block. All other workflows in this repo define concurrency.cancel-in-progress with a ${{ github.workflow }}-${{ github.ref }} group; adding the same here would prevent overlapping doc deploy triggers on rapid successive pushes to main.

Suggested change
- "CONTRIBUTING.md"
- "CONTRIBUTING.md"
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

Copilot uses AI. Check for mistakes.
Comment on lines +11 to +14
jobs:
deploy:
runs-on: ubuntu-latest
steps:
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider explicitly setting permissions for this workflow (e.g., permissions: {} or the minimal required). Most workflows in this repo declare permissions at the top level, and this job doesn't appear to need the default GITHUB_TOKEN scopes since it uses a PAT via GH_TOKEN.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants