Conversation
|
@dunglas Do you prefer to merge this or close and just try again with updated Prompt in separate PR? |
There was a problem hiding this comment.
Pull request overview
This PR updates the FrankenPHP documentation translations for performance.md across multiple languages (Turkish, Russian, French, Portuguese Brazilian, Japanese, Chinese), adding new sections (max_threads, try_files worker equivalent, and "Thread Pool Splitting") that were previously absent from the translations. It also cleans up BOM characters from Russian and Turkish config.md files, and refactors the translate.php tool by promoting the system prompt from a local variable to a top-level constant with improved translation rules.
Changes:
- Refactored
translate.php: The AI system prompt is moved from a local variable increatePrompt()to a top-levelSYSTEM_PROMPTconstant, with updated rules (specifically around link URL translation and anchor handling). - Added new and updated translated sections in
performance.mdfor all 6 supported languages (Turkish is entirely new; Russian, French, pt-br, Japanese, Chinese addmax_threads,try_filesworker equivalent, and "Thread Pool Splitting" sections). - Removed UTF-8 BOM characters from
docs/ru/config.mdanddocs/tr/config.md.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
docs/translate.php |
Moves system prompt to a top-level constant; updates translation rules for code comments, links, and anchors |
docs/tr/performance.md |
New complete Turkish translation of performance.md |
docs/tr/config.md |
Removes UTF-8 BOM character from file start |
docs/ru/performance.md |
Adds max_threads, try_files worker equivalent, and "Thread Pool Splitting" sections; code block comments in new sections left in English (not translated) |
docs/ru/config.md |
Removes UTF-8 BOM character from file start |
docs/pt-br/performance.md |
Adds/updates multiple sections; contains a broken URL (alpinux.org instead of alpinelinux.org) |
docs/ja/performance.md |
Adds worker-equivalent try_files block and "Thread Pool Splitting" section; code comments properly translated |
docs/fr/performance.md |
Adds/updates multiple sections with properly translated code comments |
docs/cn/performance.md |
Adds worker-equivalent try_files block and "Thread Pool Splitting" section; code comments properly translated |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@alexandre-daubois I've opened a new pull request, #2239, to work on those changes. Once the pull request is ready, I'll request review from you. |
…L typo (#2239) Addresses several translation issues identified in code review of the `performance.md` docs. ## `docs/ru/performance.md` - Fixed broken anchor links: `config.md#kонфигурация-caddyfile` (Latin `k`) → `config.md#конфигурация-caddyfile` (Cyrillic `к`) — appeared on two separate lines - Translated all English inline Caddyfile comments to Russian in the `try_files` section - Translated all English inline Caddyfile comments to Russian in the "Thread Pool Splitting" section ## `docs/pt-br/performance.md` - Fixed broken URL: `https://gitlab.alpinux.org/...` → `https://gitlab.alpinelinux.org/...` (missing `eline` in domain) <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: alexandre-daubois <2144837+alexandre-daubois@users.noreply.github.com>
Translation updates for: performance.md .