Skip to content

Conversation

@gimler
Copy link
Contributor

@gimler gimler commented Dec 29, 2025

We must raise twig to 3.21.0 (released 2025-05-02) to fix the test, many twig versions have security problems see https://packagist.org/packages/twig/twig

Version Tests Security
v3.22.2 ok
v3.22.1 ok
v3.22.0 ok
v3.21.1 ok
v3.21.0 ok
v3.20.0 fail
v3.19.0 fail
v3.18.0 fail
v3.17.1 fail
v3.17.0 fail
v3.16.0 fail
v3.15.0 fail
v3.14.2 fail
v3.14.1 fail
v3.14.0 fail
v3.13.0 fail
v3.12.0 fail

@gimler
Copy link
Contributor Author

gimler commented Dec 30, 2025

@bocharsky-bw please review. I have updated the pr description with more informations.

When this is merged i would open another pr to raise symfony.

],
"require": {
"php": "^8.1",
"php": "^8.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, should we bump the PHP version here too? I'm not sure. Even if we do not test the bundle on PHP 8.1 people still can use it unless we have a specific set of minimum packages that explicitly require PHP 8.2. Wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we did not change it here it suggest that we support php 8.1. So i would change it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, sounds reasonable

Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bocharsky-bw bocharsky-bw merged commit 5e43895 into php-translation:master Dec 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants