-
Notifications
You must be signed in to change notification settings - Fork 94
Update PHP versions and workflow actions in CI #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bocharsky-bw please review. I have updated the pr description with more informations. When this is merged i would open another pr to raise symfony. |
| ], | ||
| "require": { | ||
| "php": "^8.1", | ||
| "php": "^8.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, should we bump the PHP version here too? I'm not sure. Even if we do not test the bundle on PHP 8.1 people still can use it unless we have a specific set of minimum packages that explicitly require PHP 8.2. Wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we did not change it here it suggest that we support php 8.1. So i would change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, sounds reasonable
bocharsky-bw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
We must raise twig to 3.21.0 (released 2025-05-02) to fix the test, many twig versions have security problems see https://packagist.org/packages/twig/twig