Merged
Conversation
The README used Dto::create('Name')->immutable() which calls the static
factory method as an instance method with wrong signature. The correct
APIs are Dto::immutable('Name') or Dto::create('Name')->asImmutable(),
consistent with the ConfigBuilder docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
=========================================
Coverage 82.56% 82.56%
Complexity 1333 1333
=========================================
Files 40 40
Lines 3252 3252
=========================================
Hits 2685 2685
Misses 567 567 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README examples used
Dto::create('Article')->immutable()which incorrectly calls the static factory methodimmutable(string $name)as a no-argument instance method.The correct APIs are:
Dto::immutable('Article')— static factory (used in all other docs)Dto::create('Article')->asImmutable()— instance methodThis fixes the 3 occurrences in the Immutable DTOs section to use
Dto::immutable('Name'), consistent with ConfigBuilder.md and all other documentation.