Gradle support: Refactor configuration#295
Open
tburny wants to merge 9 commits intophoenixnap:masterfrom
tburny:gradle-support
Open
Gradle support: Refactor configuration#295tburny wants to merge 9 commits intophoenixnap:masterfrom tburny:gradle-support
tburny wants to merge 9 commits intophoenixnap:masterfrom
tburny:gradle-support
Conversation
…e-level classes
…rom general logic The only parametric dependency was the project base directory, which is now an explicit parameter to the method. Additionally the Maven setup by pom file was also seperated.
…rom general logic
This prepares for extracting a common configuration interface / base class that can be reused for tests and gradle
…iple implementations
…eries" logic to new MavenDefaultConfig class Seperate the Maven-specific parts of the configuration from the more general default configuration. Previously we turned the static getters/setters into instance methods and the static getters/setters are delegating to their instance counterpart. Now we can override these instance methods with Maven-specific logic without any problems.
…rites - Extract ConfigSource interface which is implemented by DefaultConfig, MavenDefaultConfig and the Mojo - MavenDefaultConfig: Replace usages of SpringMvcEndpointGeneratorMojo with ConfigSource, so we can still overlay properties from DefaultConfig
…be moved away later on
…into gradle-support # Conflicts: # src/main/java/com/phoenixnap/oss/ramlplugin/raml2code/plugin/Config.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the configuratio to be more maven-independent by splitting things apart. I added some explanations in the commits to make things easier, where a typically a commit is the result of one or two refactorings at most.
I tried to do small steps which can be verified easily. Each increment still passes all tests from
mvn test.