stdio: fix fgets(), add gets()#473
Draft
julianuziemblo wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the gets stub from posix/stubs.c and provides a functional implementation in stdio/file.c. The implementation introduces a static helper _fgets to share logic between fgets_unlocked and the new gets function, which now correctly handles locking on stdin. I have no feedback to provide as there were no review comments to evaluate.
Unit Test Results10 550 tests +7 9 892 ✅ +11 54m 11s ⏱️ +19s For more details on these failures, see this check. Results for commit 1a2af56. ± Comparison against base commit 1383f55. This pull request removes 82 and adds 89 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
julianuziemblo
force-pushed
the
julianuziemblo/#1489
branch
from
8c3af92 to
fb9fffb
Compare
nalajcie
requested changes
May 8, 2026
Member
nalajcie
left a comment
nalajcie
left a comment
There was a problem hiding this comment.
Adding multiple people before even the test were run (and failed)? Please be more mindful to the potential reviewers,
julianuziemblo
force-pushed
the
julianuziemblo/#1489
branch
from
fb9fffb to
d95659e
Compare
14 tasks
julianuziemblo
force-pushed
the
julianuziemblo/#1489
branch
from
d95659e to
578643c
Compare
julianuziemblo
force-pushed
the
julianuziemblo/#1489
branch
from
578643c to
1a2af56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: phoenix-rtos/phoenix-rtos-project#1489
Description
Motivation and Context
Types of changes
How Has This Been Tested?
ia32-generic-qemuChecklist:
Special treatment