Skip to content

Cherry-pick changes for release 3.3#472

Open
julianuziemblo wants to merge 2 commits into
release/3.3from
julianuziemblo/NIL-1077
Open

Cherry-pick changes for release 3.3#472
julianuziemblo wants to merge 2 commits into
release/3.3from
julianuziemblo/NIL-1077

Conversation

@julianuziemblo
Copy link
Copy Markdown
Contributor

destroy_dev() is a counterpart to create_dev() that allows for device removal without sending messages back to the calling port unlike remove()/unlink() functions

YT: RTOS-1254
(cherry picked from commit 098f27b)

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@julianuziemblo julianuziemblo changed the title unistd/file: add destroy_dev() Cherry-pick changes for release 3.3 May 5, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the destroy_dev function to handle the removal of device nodes. The implementation includes canonical path construction and a manual path walk to send an unlink message to the device filesystem. Feedback identifies a bug in the retry logic for devfs lookup, suggests sharing the nodevfs state at the file level for consistency, and points out a redundant lookup call that could be optimized by integrating it into the existing path walk.

Comment thread unistd/file.c Outdated
Comment thread unistd/file.c
Comment thread unistd/file.c
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/NIL-1077 branch from 1e08fb3 to 2f1407f Compare May 5, 2026 11:58
@adamgreloch
Copy link
Copy Markdown
Member

Note that now you are submitting a cherry pick that doesn't reflect master changes due to the < 3 ~> > 3 fix

@julianuziemblo
Copy link
Copy Markdown
Contributor Author

Note that now you are submitting a cherry pick that doesn't reflect master changes due to the < 3 ~> > 3 fix

Yeah, unfortunately I can't submit this change separately to master as it is overwritten on the next commit that I don't wanna submit here... Maybe this should be a separate commit with a fix, without "cherry picked from" ?

destroy_dev() is a counterpart to create_dev() that allows for device
removal without sending messages back to the calling port unlike
remove()/unlink() functions

YT: RTOS-1254
(cherry picked from commit 098f27b)
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/NIL-1077 branch from 2f1407f to a57c212 Compare May 6, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants