Cherry-pick changes for release 3.3#472
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the destroy_dev function to handle the removal of device nodes. The implementation includes canonical path construction and a manual path walk to send an unlink message to the device filesystem. Feedback identifies a bug in the retry logic for devfs lookup, suggests sharing the nodevfs state at the file level for consistency, and points out a redundant lookup call that could be optimized by integrating it into the existing path walk.
1e08fb3 to
2f1407f
Compare
|
Note that now you are submitting a cherry pick that doesn't reflect master changes due to the |
Yeah, unfortunately I can't submit this change separately to master as it is overwritten on the next commit that I don't wanna submit here... Maybe this should be a separate commit with a fix, without "cherry picked from" ? |
destroy_dev() is a counterpart to create_dev() that allows for device removal without sending messages back to the calling port unlike remove()/unlink() functions YT: RTOS-1254 (cherry picked from commit 098f27b)
YT: NIL-1077
2f1407f to
a57c212
Compare
destroy_dev() is a counterpart to create_dev() that allows for device removal without sending messages back to the calling port unlike remove()/unlink() functions
YT: RTOS-1254
(cherry picked from commit 098f27b)
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment