Skip to content

socket: implement accept() with syscalls_sys_accept4#469

Open
xvuko wants to merge 2 commits into
masterfrom
xvuko/unacceptable
Open

socket: implement accept() with syscalls_sys_accept4#469
xvuko wants to merge 2 commits into
masterfrom
xvuko/unacceptable

Conversation

@xvuko
Copy link
Copy Markdown
Contributor

@xvuko xvuko commented Apr 16, 2026

This will allow to deprecate/remove accept syscall.

TASK: RTOS-1289

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the accept function to be an inline wrapper around accept4 with a flags value of 0. Feedback suggests that implementing accept as an inline function in the header is inconsistent with other socket wrappers in the library and may introduce portability issues. It is recommended to move the implementation to the source file as a regular function.

Comment thread include/sys/socket.h
Comment thread sys/socket.c Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

Unit Test Results

10 543 tests   9 881 ✅  55m 53s ⏱️
   649 suites    662 💤
     1 files        0 ❌

Results for commit b590d94.

♻️ This comment has been updated with latest results.

xvuko added 2 commits April 16, 2026 19:10
This will allow to deprecate/remove `accept` syscall.

TASK: RTOS-1289
@xvuko xvuko force-pushed the xvuko/unacceptable branch from 86f6550 to b590d94 Compare April 16, 2026 17:12
@xvuko xvuko marked this pull request as ready for review April 16, 2026 17:36
@xvuko xvuko requested a review from Darchiv May 13, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant