socket: implement accept() with syscalls_sys_accept4#469
Open
xvuko wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the accept function to be an inline wrapper around accept4 with a flags value of 0. Feedback suggests that implementing accept as an inline function in the header is inconsistent with other socket wrappers in the library and may introduce portability issues. It is recommended to move the implementation to the source file as a regular function.
Unit Test Results10 543 tests 9 881 ✅ 55m 53s ⏱️ Results for commit b590d94. ♻️ This comment has been updated with latest results. |
TASK: RTOS-1289
This will allow to deprecate/remove `accept` syscall. TASK: RTOS-1289
86f6550 to
b590d94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow to deprecate/remove
acceptsyscall.TASK: RTOS-1289
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment