Open
Conversation
…f' option to the short code PHP8 requires stricter delineation between static and non-static calls. Replaced all "__CLASS__" statements in the the add_XXXX calls with $this to follow standards. Additionally, the main call is rewritten for the same reason. New if tests to avoid code being exercised if variables are not defined. Not quite sure that this is the correct fix though. New functionality in the shortcode. If [code ref="Jones et al. (2025)"]DOI[/code] is used, the link in the text will use "Jones et al (2025)" as the link anchor. This is useful for in-text citations - note that you can only have one distinct ref in the post.
Author
|
These fixes allow kcite to work with WP 6.8.3 and PHP8.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix PHP8 compliance, avoid some warnings associated with unset variables, and added new functionality for in-text citations.