Merged
Conversation
This commit modernizes the project infrastructure and codebase for Node 22 compatibility. Key changes include:
- Updated core dependencies: `sqlite3` (v6.0.1), `react-scripts` (v5.0.1), `typescript` (v5.9.3), and `ts-node` (v10.9.2).
- Replaced deprecated `node-sass` with `sass` (Dart Sass v1.98.0).
- Updated `Dockerfile` to use `node:22-bookworm` for the build stage and `node:22-alpine` for the final image.
- Updated `.travis.yml` and GitHub Actions (`.github/workflows/build.yml`) to test against Node 22.
- Updated `tsconfig.json` to include `es2016` in the `lib` option to support modern JavaScript features like `Array.prototype.includes`.
- Resolved TypeScript 5.x compilation errors:
- Explicitly typed caught errors as `any` in catch blocks.
- Added missing `await` for `isValidPath` calls in plugins.
- Fixed `Promise.all` tuple type casting in `document.ts`.
- Updated `@types/node` to v25.5.0 for improved Node 22 type support.
- Added `--legacy-peer-deps` to `npm install` commands across the codebase to handle strict peer dependency conflicts in the updated environment.
Verified that `npm run build` succeeds and all 259 unit tests pass.
Co-authored-by: phaze9 <816170+phaze9@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit modernizes the project infrastructure and codebase for Node 22 compatibility and fixes CI issues. Key changes include:
- Updated core dependencies: `sqlite3` (v6.0.1), `react-scripts` (v5.0.1), `typescript` (v5.9.3), and `ts-node` (v10.9.2).
- Replaced deprecated `node-sass` with `sass` (Dart Sass v1.98.0).
- Updated `Dockerfile` to use `node:22-bookworm` for the build stage and `node:22-alpine` for the final image.
- Updated `.travis.yml` and GitHub Actions (`.github/workflows/build.yml`) to test against Node 22.
- Updated `tsconfig.json` to include `es2016` in the `lib` option to support modern JavaScript features like `Array.prototype.includes`.
- Resolved TypeScript 5.x compilation errors:
- Explicitly typed caught errors as `any` in catch blocks.
- Added missing `await` for `isValidPath` calls in plugins.
- Fixed `Promise.all` tuple type casting in `document.ts`.
- Updated `@types/node` to v25.5.0 for improved Node 22 type support.
- Added `--legacy-peer-deps` to `npm install` commands across the codebase to handle strict peer dependency conflicts.
- Fixed ESLint warnings that caused CI failures:
- Removed unused imports (`LocalStorageBackend`, `Col`).
- Fixed accessibility issues in `AppComponent`.
- Resolved regex control character and template string warnings.
- Added missing semicolons and ensured correct usage of `forEach` instead of `map`.
Verified that `npm run build`, `npm run lint`, and all 259 unit tests pass.
Co-authored-by: phaze9 <816170+phaze9@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize the project to run on Node 22 and npm 11, including dependency updates, CI/CD configuration changes, and TypeScript compilation fixes.
PR created automatically by Jules for task 11411586427021612566 started by @phaze9