Open
Conversation
a04350f to
19e8cb7
Compare
…o build_lut_updates
…o build_lut_updates
…ates Fixed Sobel sampling for build_luts
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the updates for the build_lut scripts with all of the hooks working with Isofit 3. It may need another pair of eyes to validate that the configs generated have all of the necessary components.
This also includes a new flag in the cli to make the grid via a sobel sequence. I tried the match the Julia code from the Sobel branch. The regular and Sobel grids used are still hard coded into the python script. The regular grid is the same as what is on the original branch. The Sobel grid is smaller (from my testing)
In the Sobel grid generation, I've made it possible to generate different lengths of lut elements. This should be pretty self-explanatory in the code.
So far I haven't done too much rigorous testing.
This will also need a PR on Isofit to go through to run properly. I'll attempt to link the two.