Skip to content

fix: Allow dash in pfsense alias names #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
astephanh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Allow dash in pfsense alias names #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/lookup/pfsense.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1365,8 +1365,8 @@ def __init__(self, data):
def check_alias_name(name):
""" check an alias name """
# todo: check reserved keywords (any, self, ...)
if re.match('^[a-zA-Z0-9_]+$', name) is None:
raise AnsibleError(name + ': the name of the alias may only consist of the characters "a-z, A-Z, 0-9 and _"')
if re.match('^[a-zA-Z0-9_-]+$', name) is None:
raise AnsibleError(name + ': the name of the alias may only consist of the characters "a-z, A-Z, 0-9, - and _"')

def parse_host_alias(self, obj, src_name, type_name, name, allow_any, dns_servers=None):
""" Parse an host alias definition """
Expand Down