Fixed highligting during scrolling when comment row ends with */#15
Open
mirao wants to merge 1 commit intopflenker:masterfrom
Open
Fixed highligting during scrolling when comment row ends with */#15mirao wants to merge 1 commit intopflenker:masterfrom
mirao wants to merge 1 commit intopflenker:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you run
cargo run ~/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/vec/mod.rsand scroll to (or find) the string/* INVARIANTyou get incorrectly parsed comments:
The check of
*/should producereturn false, because ending*/means that multiple line comment is ended and doesn't continue on next line.Actually I've found out that it's not needed to test multiline comments at all if row is already highlighted and just return
falsein all cases.Then it works well (and editor is still fast and without issues, at least I didn't find any):