Skip to content

Page templates content alignments #88#165

Open
Aiste-Tamos wants to merge 2 commits into
pets-oss:mainfrom
Aiste-Tamos:88-page-templates-content-alignments
Open

Page templates content alignments #88#165
Aiste-Tamos wants to merge 2 commits into
pets-oss:mainfrom
Aiste-Tamos:88-page-templates-content-alignments

Conversation

@Aiste-Tamos

@Aiste-Tamos Aiste-Tamos commented May 4, 2021

Copy link
Copy Markdown

Aligned mentioned content items to center, but question is if titles at "About" or "User profile" pages should be centered too?

Resolves #88

@saulyz saulyz self-requested a review May 5, 2021 08:04
Comment thread src/pages/Page.tsx
display: 'flex',
justifyContent: 'center',
alignItems: 'flex-start',
alignItems: 'center',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a sufficient solution, as you have already noticed and asked in the comments.
I'd suggest creating a wrapper component in the src/components/layout and then use this wrapper for components that do not take the whole page width.
Similar to the content style rules here.

@saulyz

saulyz commented May 10, 2021

Copy link
Copy Markdown
Collaborator

Please try doing the wrapper component.
Use it in About, User profile, NewAnimalPage (internal elements)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page templates content alignments

2 participants