#151 Create organization tasks page#159
Open
LukasKri wants to merge 1 commit into
Open
Conversation
budaman
reviewed
May 7, 2021
budaman
left a comment
budaman
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, pretty clean, and the required implementation is done correctly. The only improvement we could have tests for the page and Organization task card as a separate component.
budaman
reviewed
May 7, 2021
| return ( | ||
| <Page title="Organization Tasks"> | ||
| {data && | ||
| data.organizationTasks.map(task => { |
Collaborator
There was a problem hiding this comment.
Missing a OrganizationTask type
Contributor
Author
There was a problem hiding this comment.
Thank you, I added the type. Do you want me to extract the Organization task card as a separate component or just leave it for the future improvements?
LukasKri
force-pushed
the
151-create-organization-tasks-page
branch
from
30654b6 to
7ac7233
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created organization tasks page with proper styles. I'm planning to add tests later.
Resolves #151.