Translate code on english #69
Conversation
|
Thanks for the PR (and the other one in Li-ri-devel). As said in another issue, bumping the year is clearly not the most important for now (as there is no release planned for now). How much do you want to work on improving the game? On my side, I mostly plan to only do minor changes and keep it alive and up-to-date, so I don't have big plans to add new features or major improvements. I've opened a few ideas that could help with the maintenance (such as using sdl_ttf for the texts instead of images, because as you saw, generating the data is complicated and if we want to add languages, it will not be easy or more easy or having the option to not have the human rights questions). Is it something you'd like to work on? |
|
Yes, I’m interested in helping in Li-Ri project. I see potential in this project. :D |
zabidenhtf
changed the title
|
Hello, I have a small question would you be able to merge my PR? |
Regarding the copyright, I think I'll prefer to do it myself when I'll want to create a new release: the main point is that for the image you didn't use the same font, so I would like to ensure I use the same one as before. |
src/utils.h
Outdated
|
|
||
| static bool LoadPref(); // Load preferences | ||
| static void SauvePref(); // Save preferences | ||
| static void SavePref(); // Save preferences |
There was a problem hiding this comment.
I would go with SavePreferences() and remove the comment (ideally same for LoadPreferences above)
src/preference.h
Outdated
| }; | ||
|
|
||
| enum eMenu { | ||
| enum eMenu { // TODO: Rename |
src/preference.h
Outdated
| }; | ||
|
|
||
| struct sNewPreference | ||
| struct sNewPreference // Here too |
src/preference.h
Outdated
| #define ECARTWAGON_MOY 13.0 | ||
| #define ECARTWAGON_MIN 4.0 | ||
| #define REDUCED_DURATION (10 * 1000) | ||
| #define ALONGE_DURATION (10 * 1000) |
There was a problem hiding this comment.
the French term is allonger, which means extend (https://www.wordreference.com/fren/allonger), I would suggest to use EXTENSION instead of ALONGE (and REDUCTION instead of REDUCED above)
src/main.cc
Outdated
| Level level; // Gère les niveaux | ||
| Sprite *Sprites = nullptr; // Sprites pointer | ||
| int NSprites = 0; // Number of sprites in memory | ||
| Screen Ec; // 2 Video buffer pointer TODO: RENAME |
There was a problem hiding this comment.
would be nice if we can remove the TODO. Maybe call it screens (Ec is short for Ecran which is a screen in English)
There was a problem hiding this comment.
and in my opinion will be good rename this object to screenObj
There was a problem hiding this comment.
what does the "Obj" suffix bring?
Also, it would be better to avoid using acronyms or abbrevations if possible because the code is more often read than written, so even if you gain a few seconds by not typing the full word, people who will read the code will lose more time trying to understand its meaning
src/main.cc
Outdated
| #include "level.h" | ||
| #include "editor.h" | ||
| #include "utils.h" | ||
| #include "utils.h" // Done |
|
Ok, I'm will fix my errors |
|
Fixed |
zabidenhtf
changed the title
|
Hello, im removed copyright update from repository. |
2 participants
No description provided.