Initialize uninitialized double values during gain calculation#1
Open
BrandenAvalonCx wants to merge 1 commit intopeterStitt:master-oldfrom
Open
Initialize uninitialized double values during gain calculation#1BrandenAvalonCx wants to merge 1 commit intopeterStitt:master-oldfrom
BrandenAvalonCx wants to merge 1 commit intopeterStitt:master-oldfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling for release using Clang 14.0.3, these 2 doubles are uninitialized, causing them to be arbitrary values, which leads to errors in the gain calculations. Note that I only encountered the problem on non-debug builds and only when panning to the stereo layout, debug builds and non-stereo layouts seem to work fine.
To reproduce the issue:
Initializing these uninitialized variables resolves the issue.
Working with libspatialaudio on Mac Sonoma 14.7.1, compiling with Clang 14.0.3.
Please let me know if I can provide any additional information, formatting, etc.