make it possible to distinguish update and add notifications.#65
Open
neonstalwart wants to merge 1 commit intopersvr:masterfrom
Open
make it possible to distinguish update and add notifications.#65neonstalwart wants to merge 1 commit intopersvr:masterfrom
neonstalwart wants to merge 1 commit intopersvr:masterfrom
Conversation
neonstalwart
force-pushed
the
add-topic
branch
from
34d66a0 to
813a463
Compare
neonstalwart
force-pushed
the
add-topic
branch
from
813a463 to
7d994a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when subscribing to perstore, all notifications are either
'update'or'delete'. i'm using dstore as a client and it handles'add'differently to'update'. it's not possible to infer whether or not an'update'from perstore is really an'update'or an'add'. it would be good to introduce an explicit'add'topic or at least make it possible to infer an'add'from an'update'topic.