fix: address Copilot review comments on klick-deploy package import#4
Draft
fix: address Copilot review comments on klick-deploy package import#4
Conversation
Co-authored-by: tomgrv <1809566+tomgrv@users.noreply.github.com>
Agent-Logs-Url: https://github.com/perspikapps/klick-deploy/sessions/f3200e84-6fd0-4e3d-8177-642abbdfd3a2 Co-authored-by: tomgrv <1809566+tomgrv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Automated sync from perspikapps/flekskit to klick-deploy
fix: address Copilot review comments on klick-deploy package import
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the automated sync from
perspikapps/flekskit(PR #2) and resolves all 16 Copilot review findings — covering shell injection vectors, silent failure paths, incorrect docblocks/descriptions, and a broken CI output key.Security / correctness
set_env.php: Validate secret keys against^[A-Z0-9_]+$before interpolating into shell commands/sed patternscpanel.php:escapeshellarg()applied to module name, function name, and everykey=valueargument inuapi()set_version.php: Replace bareecho $version$buildwithprintf %s+escapeshellargto prevent metacharacter injectionupload_assets.php: Use the configured$gitbinary (not hardcodedgit) inrunLocally;escapeshellarg($path)for directory check;trim()SHAs before strict!==comparison; fix directory-existence check to use&& echo 1 || echo 0pattern instead of unreliable exit-code comparisonBug fixes
cpanel_mail.php: Remove trailing space from'passwd_pop 'UAPI function name; throw on non-1update status instead of silently continuingcpanel_domain.php: Fixarray_search()result mixed into boolean expression —searchDomain(...) !== falsewith explicit$rootExistsboolplatform_savepub.php: Replace non-existentwarn()with Deployer'swarning()src/main.php: Wrapkeep_releasesin a closure soisUnstable()is evaluated per-host at task time, not at recipe load timeactions/run-deployer/action.yml: Fix mismatched output keyphp-packages=false→packages=falsesosteps.check.outputs.packagesis populated in both branchescomposer.json: Remove Laravel-specific lifecycle scripts (post-autoload-dump/post-create-project-cmd/post-root-package-install/post-update-cmd) that referenceartisanandIlluminate\Foundation— absent in this libraryDocs / metadata
readme.md: Replace removedstrategy_*.phpimport paths withsrc/main.phpCHANGELOG.md: Removeplatform:crontab:removeentry — task is not implementedplatform_knownhosts.php: Correct copy-pasted docblock (described env vars; actually manages SSH known_hosts)platform_listhosts.php: Same — fix docblock to describe host listingplatform_encrypt.php: Fixdesc('List selected hosts')→desc('Encrypt a value for the current host')