Skip to content

Adding support for EU region#137

Merged
EliMoshkovich merged 7 commits intomainfrom
PER-12979-add-eu-support-by-flag
Oct 15, 2025
Merged

Adding support for EU region#137
EliMoshkovich merged 7 commits intomainfrom
PER-12979-add-eu-support-by-flag

Conversation

@EliMoshkovich
Copy link
Contributor

Pull Request

Description

Type of Change

  • Bug fix
  • New feature/command
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition/update
  • Other (please describe):

Checklist

  • I have created an issue and linked it in this PR
  • I have created a branch from main with an appropriate name (e.g., fix/issue-123, feature/new-command)
  • My code follows the project's coding style guidelines
  • I have added tests for my changes (>90% coverage of new code)
  • I have updated the documentation if necessary
  • All tests pass locally
  • Lint checks pass locally
  • I have reviewed my own code for potential issues

New Command Details (if applicable)

  • Command is placed in the src/commands directory
  • Command file contains only argument configuration and a root command component
  • Command is wrapped with the AuthProvider component
  • Command has an optional apiKey argument
  • API key scope is declared for the command
  • Documentation added to the README

Additional Notes

Screenshots/Recordings

@orweis
Copy link
Collaborator

orweis commented Oct 3, 2025

Looks good all in all;
How about some tests? :)

Copy link
Collaborator

@orweis orweis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some added suggestions but not blockers; assuming all tests pass; and user confirms basic usage

@EliMoshkovich EliMoshkovich merged commit 6456189 into main Oct 15, 2025
3 checks passed
@EliMoshkovich EliMoshkovich deleted the PER-12979-add-eu-support-by-flag branch October 15, 2025 16:47
Tabintel pushed a commit to Tabintel/permit-cli that referenced this pull request Dec 5, 2025
* Adding support for EU region

* Tests added

* Fix OAuth Login Bug, API Key Validation Bug, Terraform Export Bug, Infinite Loop Bug with policy create simple, Missing Actions Bug

* Default roles added for exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants