Unclock improvments and simulator reset during start #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onsdagens
reviewed
Aug 27, 2025
Collaborator
onsdagens
left a comment
onsdagens
left a comment
There was a problem hiding this comment.
i can't find an implementation of this function where the simulator is not under an anonymous identifier, do we actually need the argument?
onsdagens
approved these changes
Aug 27, 2025
Collaborator
onsdagens
left a comment
onsdagens
left a comment
There was a problem hiding this comment.
we discussed this in person, it's not used as is, but is nifty to have for later. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Simulator as a parameter to the unclock method of components, changing its signature to
unclock(&self, sim: &Simulator). This allows components to access their inputs and outputs during the undo cycle, simplifying state management and enabling easier reversion of state when needed.unclock is also called in the reverse order compared to clock
Additionally, when a simulator is created using new, it automatically calls reset on all components. This reset call can be used to set initial values, define signal formats, and perform any other necessary setup.