Skip to content

Mips fix data memory view & more #[serde(skip)] #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakobkieri wants to merge 18 commits into from
Closed

Mips fix data memory view & more #[serde(skip)] #107

jakobkieri wants to merge 18 commits into from

Conversation

@jakobkieri
Copy link
Contributor

@jakobkieri jakobkieri commented Aug 6, 2025

Prerequisite: #104 (comment)

added:

  • functional unclock() and reset() behaviour for datamemory
  • #[serde(skip)] to fields in mem_view_window

removed:

  • unused .json

onsdagens
onsdagens reviewed Aug 7, 2025
View reviewed changes
Copy link
Collaborator

@onsdagens onsdagens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks

@jakobkieri jakobkieri closed this Sep 12, 2025
@jakobkieri jakobkieri deleted the mips_fix_data_memory_view branch September 12, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perlindgren perlindgren perlindgren left review comments

@onsdagens onsdagens onsdagens left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakobkieri @perlindgren @onsdagens