PT-2218 - Add test to check per container logs for pxc#1101
Open
PT-2218 - Add test to check per container logs for pxc#1101
Conversation
svetasmirnova
approved these changes
Apr 2, 2026
artemgavrilov
approved these changes
Apr 7, 2026
| continue | ||
| } | ||
|
|
||
| if !slices.Contains(result, b) && b != "." && b != "" { |
Contributor
There was a problem hiding this comment.
Not sure under what circumstances b may be dot or empty here if we explicitly compare it with required few lines above?
Contributor
Author
There was a problem hiding this comment.
Agreed, it is a excess defensive check. I will remove it.
| "logs.log": true, | ||
| "pxc-init.log": true, | ||
| "pxc.log": true, | ||
| } |
Contributor
There was a problem hiding this comment.
Minor: It's better to implement sets like map[string]struct{} and use _, ok := required[b] to check if value is there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue have been fixed since #1054 was merged. This PR introduces modification of already existing test, to check if logs are indeed separated by container for
pxc.