Skip to content

K8SPS-96 compressed backups improv#1294

Merged
egegunes merged 12 commits intomainfrom
K8SPS-96-compressed-backups-improv
Apr 15, 2026
Merged

K8SPS-96 compressed backups improv#1294
egegunes merged 12 commits intomainfrom
K8SPS-96-compressed-backups-improv

Conversation

@gkech
Copy link
Copy Markdown
Contributor

@gkech gkech commented Apr 13, 2026

CHANGE DESCRIPTION

Problem:

Compression can be configured using the configuration option of mysql defined in CR, as well as arguments. The status of backups that are compressed should consider that possibility and reflect that.

Also changing the default algorithm used for the e2e tests for compression, since we are observing issues related to that: https://perconadev.atlassian.net/browse/PXB-3568

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PS version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Apr 13, 2026
@hors hors added this to the v1.1.0 milestone Apr 14, 2026
@hors hors changed the title K8SPS 96 compressed backups improv K8SPS-96 compressed backups improv Apr 14, 2026
@gkech gkech marked this pull request as ready for review April 14, 2026 15:34
@gkech gkech requested a review from nmarukovich as a code owner April 14, 2026 15:34
return isCompressedInMySQLConfig(mysqlConfiguration)
}

func isCompressedInMySQLConfig(configuration string) bool {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this is okay, but did we consider using something like go-ini to automatically parse such config?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'm planning of extracting the logic from cmd/bootstrap/gr/config.go to a shared package, exported, etc and reuse it here. I'm going to open that in a new PR cause the e2e tests are already running and it can be just an improvement.

mayankshah1607
mayankshah1607 previously approved these changes Apr 15, 2026
mayankshah1607
mayankshah1607 previously approved these changes Apr 15, 2026
@JNKPercona
Copy link
Copy Markdown
Collaborator

Test Name Result Time
async-ignore-annotations-8-4 passed 00:06:35
async-global-metadata-8-4 passed 00:14:41
async-upgrade-8-0 passed 00:12:46
async-upgrade-8-4 passed 00:12:29
auto-config-8-4 passed 00:24:26
config-8-4 passed 00:20:58
config-router-8-0 passed 00:07:27
config-router-8-4 passed 00:07:29
demand-backup-8-0 passed 00:19:59
demand-backup-8-4 passed 00:20:21
demand-backup-cloud-8-4 passed 00:22:01
demand-backup-retry-8-4 passed 00:17:10
demand-backup-incremental-8-0 passed 00:39:41
demand-backup-incremental-8-4 passed 00:39:30
async-data-at-rest-encryption-8-0 passed 00:13:14
async-data-at-rest-encryption-8-4 passed 00:13:18
gr-global-metadata-8-4 passed 00:14:26
gr-data-at-rest-encryption-8-0 passed 00:16:51
gr-data-at-rest-encryption-8-4 passed 00:14:30
gr-demand-backup-8-4 passed 00:13:46
gr-demand-backup-cloud-8-4 passed 00:23:21
gr-demand-backup-haproxy-8-4 passed 00:09:51
gr-demand-backup-incremental-8-0 passed 00:42:17
gr-demand-backup-incremental-8-4 passed 00:42:50
gr-finalizer-8-4 passed 00:05:57
gr-haproxy-8-0 passed 00:04:44
gr-haproxy-8-4 passed 00:04:10
gr-ignore-annotations-8-4 passed 00:04:59
gr-init-deploy-8-0 passed 00:09:17
gr-init-deploy-8-4 passed 00:09:34
gr-one-pod-8-4 passed 00:05:19
gr-recreate-8-4 passed 00:17:01
gr-scaling-8-4 passed 00:07:57
gr-scheduled-backup-8-4 passed 00:17:22
gr-scheduled-backup-incremental-8-4 passed 00:23:05
gr-security-context-8-4 passed 00:09:39
gr-self-healing-8-4 passed 00:24:21
gr-tls-cert-manager-8-4 passed 00:08:42
gr-users-8-4 passed 00:05:29
gr-upgrade-8-0 passed 00:09:13
gr-upgrade-8-4 passed 00:09:29
haproxy-8-0 passed 00:08:19
haproxy-8-4 passed 00:08:33
init-deploy-8-0 passed 00:05:41
init-deploy-8-4 passed 00:05:31
limits-8-4 passed 00:06:47
monitoring-8-4 passed 00:13:40
one-pod-8-0 passed 00:05:29
one-pod-8-4 passed 00:06:08
operator-self-healing-8-4 passed 00:11:13
pvc-resize-8-4 passed 00:05:57
recreate-8-4 passed 00:12:38
scaling-8-4 passed 00:10:58
scheduled-backup-8-0 passed 00:16:10
scheduled-backup-8-4 passed 00:14:04
scheduled-backup-incremental-8-0 passed 00:22:07
scheduled-backup-incremental-8-4 passed 00:21:59
service-per-pod-8-4 passed 00:06:37
sidecars-8-4 passed 00:04:20
smart-update-8-4 passed 00:09:41
storage-8-4 passed 00:04:06
telemetry-8-4 passed 00:06:07
tls-cert-manager-8-4 passed 00:11:09
users-8-0 passed 00:07:37
users-8-4 passed 00:07:36
version-service-8-4 passed 00:18:55
Summary Value
Tests Run 66/66
Job Duration 02:24:39
Total Test Time 14:58:08

commit: 904c24e
image: perconalab/percona-server-mysql-operator:PR-1294-904c24e8

@egegunes egegunes merged commit 679e3ae into main Apr 15, 2026
15 of 16 checks passed
@egegunes egegunes deleted the K8SPS-96-compressed-backups-improv branch April 15, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L 100-499 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants