K8SPS-410 | move incremental backups proposal to completed#1269
K8SPS-410 | move incremental backups proposal to completed#1269mayankshah1607 wants to merge 6 commits intomainfrom
Conversation
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
There was a problem hiding this comment.
Pull request overview
Updates the incremental backups enhancement document metadata to reflect that the proposal has been completed, aligning it with the merged implementation PR.
Changes:
- Mark the proposal status as Completed (with a link to the implementing PR).
- Update “Last Updated” date and populate the reviewers list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| |--------------|--------------------| | ||
| | Author | @mayankshah1607 | | ||
| | Status | In review | | ||
| | Status | [Completed](https://github.com/percona/percona-server-mysql-operator/pull/1254) | |
There was a problem hiding this comment.
The enhancements TEMPLATE defines Status as a single value from Draft / In Review / Approved / Completed. Making it a Markdown link means the value is no longer exactly Completed, which can break consistency (and any future grep/tooling over statuses). Consider keeping Status as plain Completed and adding the PR link separately (e.g., in parentheses or an additional line/section).
| | Status | [Completed](https://github.com/percona/percona-server-mysql-operator/pull/1254) | | |
| | Status | Completed | | |
| | PR | https://github.com/percona/percona-server-mysql-operator/pull/1254 | |
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
egegunes
left a comment
There was a problem hiding this comment.
I wouldn't move to Completed before QA
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
commit: fbab649 |
|
e2eignore still doesn't work |
Will try to fix here: |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | Reviewers | @egegunes @gkech @hors | | ||
| | Implementation | https://github.com/percona/percona-server-mysql-operator/pull/1269 | |
There was a problem hiding this comment.
The metadata table rows for Reviewers/Implementation have a lot of extra padding whitespace, which makes diffs noisier and can cause markdown linters/editors to flag trailing spaces. Consider trimming trailing spaces and keeping column spacing consistent with the header rows.
| | Reviewers | @egegunes @gkech @hors | | |
| | Implementation | https://github.com/percona/percona-server-mysql-operator/pull/1269 | | |
| | Reviewers | @egegunes @gkech @hors | | |
| | Implementation | https://github.com/percona/percona-server-mysql-operator/pull/1269 | |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.