Skip to content

K8SPXC-1754 Updated the update certificates doc with automated steps#307

Open
nastena1606 wants to merge 1 commit intomainfrom
K8SPXC-1754-Doc-automate-cert-update
Open

K8SPXC-1754 Updated the update certificates doc with automated steps#307
nastena1606 wants to merge 1 commit intomainfrom
K8SPXC-1754-Doc-automate-cert-update

Conversation

@nastena1606
Copy link
Copy Markdown
Collaborator

Enhanced instructions for checking certificate expiration and validity, and improved overall wording for better clarity.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the TLS certificate rotation documentation to add more structured, automated steps for checking certificate validity/expiration and for updating certificates via the Operator, with improved wording and navigation.

Changes:

  • Added a “Before you start” section to standardize using a $NAMESPACE environment variable.
  • Restructured the “Check your certificates for expiration” section into cert-manager vs non–cert-manager tabs with example outputs.
  • Rewrote the “update certificates” instructions to describe an Operator-driven automated update flow (via a *-new Secret) and clarified the downtime flow for expired certs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/tls-update.md
Comment on lines +68 to +71
```{.text .no-copy}
notBefore=Nov 7 10:54:00 2025 GMT
notAfter=Nov 7 10:54:00 2026 GMT
```
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample output (notBefore/notAfter) doesn’t match the command shown (openssl ... -text | grep "Not After"), which would typically only print a Not After line (and not notBefore). Update the command (e.g., use -noout -dates and/or adjust grep) or adjust the sample output to match.

Copilot uses AI. Check for mistakes.
Comment thread docs/tls-update.md Outdated
Comment thread docs/tls-update.md Outdated
Comment on lines +126 to +130
2. Create a Secrets object and supply the new certificates within it. The Secret name must be in the format `<existing-secret>-new`. For example, if the existing Secret name is `cluster1-ssl-internal`, the new Secret name is `cluster1-ssl-internal-new`. The command to create it is:

```bash
kubectl get secret/cluster1-ssl -o jsonpath='{.data.ca\.crt}' | base64 --decode > ca.pem.old
kubectl get secret/cluster1-ssl -o jsonpath='{.data.tls\.crt}' | base64 --decode > tls.pem.old
kubectl get secret/cluster1-ssl -o jsonpath='{.data.tls\.key}' | base64 --decode > tls.key.old
kubectl -n $NAMESPACE create secret generic cluster1-ssl-internal-new \
--from-file=ca.crt=ca.crt \
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update command creates a generic Secret (which defaults to type Opaque), but earlier this page suggests TLS Secrets should be kubernetes.io/tls. Consider setting the Secret type explicitly (and/or using the appropriate kubectl create secret tls flow). Also, step 1 references generating ca.pem/server.pem/server-key.pem, but this command uses ca.crt/tls.crt/tls.key—please align the filenames so the instructions are consistent and runnable.

Copilot uses AI. Check for mistakes.
Comment thread docs/tls-update.md Outdated
Comment thread docs/tls-update.md Outdated
Enhanced instructions for checking certificate expiration and validity, and improved overall wording for better clarity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants