Fix typo and improve readability and documentation in README.md #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FourZone keyboard color control path is in `/sys/devices/platform` and not `/sys/devices/platforms/`.
Note: the Fn-Esc hotkey is taken from [this commit](wl2776@6446d58) in a separate fork of this project. I'm not sure if it's correct.
Contributor
|
Pressing Fn+Esc indeed generates event 0x21A7 on my notebook. I've sent acpidump from my notebook to @pelrun and he has found that event code in it. You can see conversation about it in #9. Then I've accidentally found what key combination generates it by running |
Owner
|
I don't really see much of an readability "improvement" here, it's simply changing my writing style to yours. That said there's at least some added information so I'll try to get over it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes a typo in the first path to the keyboard color control files.
The second commit makes various grammar/structural changes and adds more information about the Omen-specific hotkeys.