fix(requiresMainQueueSetup): stop warning requiresMainQueueSetup #59#62
Open
numandev1 wants to merge 1 commit intopeggyrayzis:masterfrom
Open
fix(requiresMainQueueSetup): stop warning requiresMainQueueSetup #59#62numandev1 wants to merge 1 commit intopeggyrayzis:masterfrom
numandev1 wants to merge 1 commit intopeggyrayzis:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#59
What:
i added requiresMainQueueSetup method to templates/ui-components/ios-objc/TemplateManager.m
Why:
because with the latest version of react native, we are getting warning "requiresMainQueueSetup"
How:
i made new branch as mention in contributor docs and i added requiresMainQueueSetup method to templates/ui-components/ios-objc/TemplateManager.m after that i run npm run test after that update test by npm test -- -u && npm run test and after that i tested on my project
Checklist: