Draft
Conversation
added 2 commits
March 6, 2026 22:59
hellcp
reviewed
Mar 8, 2026
Member
There was a problem hiding this comment.
We don't need this change, you should just drop it
timeline_sync/__init__.py
Outdated
| init_app(app) | ||
| init_api(app) # Includes both private (timeline-sync) and public (timeline-api) APIs | ||
|
|
||
| cred = credentials.Certificate('./google-services.json') |
Member
There was a problem hiding this comment.
This won't work, we need a config as env, not as a file, since the filesystem on the deployed workers always changes
Author
There was a problem hiding this comment.
can you check how it can be achieve?
It can see that we can inject json as env as well, but I am only seeing this using a json file either for services.json or service-account.json
Member
There was a problem hiding this comment.
There are a couple ways, some mentioned in https://firebase.google.com/docs/admin/setup#initialize_the_sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This support registering and sending fcm to core app, this only supports user pins.
Here is the mobile side of implementation coredevices/mobileapp#131
we need to update submodule of rws_common with
The update to python 3.9 is require due to firebase 7.2.0 have the functions such as 'send_each_for_multicast' which is required.