Fix stale rendering and shutdown race on terminal resize#39
Open
reisub wants to merge 1 commit into
Open
Conversation
Drain the message queue between broadcasting Resize and rendering, so the first frame after a resize reflects updated component state instead of the previous frame's. Replace the unconditional backend.clear with the diff renderer's erase cells when a buffer_manager is in play, falling back to a real clear for buffer-less backends. Skip the post-resize render if a component's update returned :quit so we don't paint into a backend that's about to be torn down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, thanks for the great lib - definitely fills a gap in the Elixir world!
I'm working on a TUI app and I ran into an issue where resizing the terminal window doesn't correctly re-render the UI if there hasn't been an update after the resize.
I'm not super familiar with the codebase, so this is a Claude assisted fix which I've iterated on and confirmed that it fixes the issue I ran into.
Changes: