Fix Theme.style_from_theme/4 calling undefined Style.from/1#18
Merged
Merged
Conversation
Theme aliases TermUI.Renderer.Style but was calling Style.from/1, which only exists in TermUI.Style. This caused UndefinedFunctionError when style_from_theme/4 was invoked. Changed to Style.new/1 which exists in Renderer.Style and accepts the same keyword list argument. Also added has_attr?/2 to Renderer.Style for API parity, and updated test aliases to match the actual return type. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: there a several different reasons why tests are failing on
develop. This PR addresses one of them. But the CI build will be red because it doesn't address the others (saved for follow work). I'm also open to instead opening a PR with all the fixes for all the failing tests.Summary
Theme.style_from_theme/4crashed withUndefinedFunctionErrorbecause it calledStyle.from/1which doesn't exist inTermUI.Renderer.Stylehas_attr?/2toTermUI.Renderer.Stylefor API parityTermUI.Renderer.Style)Details
theme.exaliasesTermUI.Renderer.StyleasStyle, but line 428 was callingStyle.from(overrides). This function only exists inTermUI.Style, notTermUI.Renderer.Style. Changed toStyle.new(overrides)which exists and accepts the same keyword list argument.Test plan
🤖 Generated with Claude Code