Shahab-homework#23
Open
Shahab13 wants to merge 1 commit into
Open
Conversation
bwreid
reviewed
Aug 10, 2019
bwreid
left a comment
bwreid
left a comment
Collaborator
There was a problem hiding this comment.
On the whole this looks good. Just a few things left to do!
| const response = await Book.findById(book._id).select('-__v') | ||
| const status = 200 | ||
| res.json({ status, response }) | ||
| book.reserved.memberId = req.userData; |
Collaborator
There was a problem hiding this comment.
Wont' this assign the memberId to be the entire object that is userData?
| }); | ||
| } | ||
| /// | ||
| }); |
Collaborator
There was a problem hiding this comment.
This looks good but this function is quite long!
| if (order) { | ||
| if (!order.admin) { | ||
| return res.status(401).json({ | ||
| message: "The JWT token is for a user who is not an admin" |
Collaborator
There was a problem hiding this comment.
I think this is just checking whether or not the User you just found is an admin, not that the JWT Token is for an admin.
|
|
||
| console.log(message); | ||
| res.status(status).json({ status, message }); | ||
| }); |
Collaborator
There was a problem hiding this comment.
This route yet to be implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.