adding what i could#16
Open
jaamp wants to merge 1 commit into
Open
Conversation
bwreid
reviewed
Aug 17, 2019
bwreid
left a comment
bwreid
left a comment
Collaborator
There was a problem hiding this comment.
Still some work to do, but you have a nice start!
| error.status = 400 | ||
| next(error) | ||
| } | ||
| }) |
| const user = await User.findOne({username}) | ||
| if (user) throw new Error('User name is already in use') | ||
|
|
||
| const saltRounds = 5 |
Collaborator
There was a problem hiding this comment.
You'll want to make a more secure password and at least use 8 rounds.
| } | ||
| const payload = {id: user._id} | ||
| const options = {expiresIn: '1 day'} | ||
| const token = jsonwebtoken.sign(payload, 'ASECRETPASSCODE', options) |
Collaborator
There was a problem hiding this comment.
'ASECRETPASSCODE' should be put into your nodemon.json or otherwise excluded from your code. It's insecure/inefficient to do so otherwise.
| router.patch('/:id/reserve', async (req, res, next) => { | ||
| const { id } = req.params | ||
| try { | ||
| if (req.headers.authorization === null) { |
Collaborator
There was a problem hiding this comment.
This doesn't actually check to see whether or not someone is logged in, it only checks to see whether or not someone has sent over a token. If the token is invalid, it will pass with the given code.
| "dev": "nodemon app.js", | ||
| "reset-db": "node ./db/seeds" | ||
| "reset-db": "node ./db/seeds", | ||
| "reset-db2": "node ./db/seeds2" |
Collaborator
There was a problem hiding this comment.
Instead of creating a second file, I would just add this to the existing seeds file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.