Add local $ref resolution helpers and propagate nested-ref document context#542
Open
andreyyudin wants to merge 1 commit intopb33f:mainfrom
Open
Add local $ref resolution helpers and propagate nested-ref document context#542andreyyudin wants to merge 1 commit intopb33f:mainfrom
$ref resolution helpers and propagate nested-ref document context#542andreyyudin wants to merge 1 commit intopb33f:mainfrom
Conversation
- add ResolveReferenceValue with SpecIndex lookup and local JSON Pointer fallback - add ResolveRefsInNode to recursively resolve local $ref mappings and merge sibling fields - add ResolveNestedRefsWithDocumentContext to DocumentConfiguration and wire it through v2/v3 document creation - map ResolveNestedRefsWithDocumentContext in SpecIndexConfig.ToDocumentConfiguration - expand tests for helper behavior and config propagation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #542 +/- ##
========================================
Coverage 99.60% 99.61%
========================================
Files 234 236 +2
Lines 27886 28033 +147
========================================
+ Hits 27777 27926 +149
+ Misses 66 65 -1
+ Partials 43 42 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds reusable local reference-resolution helpers and ensures nested-reference context settings are consistently propagated from document-level config into index/resolver config.
What changed
ResolveReferenceValueinindex:SpecIndexwhen available.#/#/...) via document data provider.ResolveRefsInNodeinindex:$refvalues in YAML nodes.ResolveNestedRefsWithDocumentContexttodatamodel.DocumentConfiguration.ResolveNestedRefsWithDocumentContextthrough:datamodel/low/v2/createDocumentdatamodel/low/v3/createDocumentSpecIndexConfig.ToDocumentConfigurationmappingWhy
Nested relative refs can require document-context-aware resolution to behave correctly across split specs. This PR makes that behavior configurable end-to-end and adds reusable helpers for local
$refhandling and pointer resolution.Compatibility
ResolveNestedRefsWithDocumentContextis explicitly enabled.