Skip to content

Conversation

@wozozo
Copy link
Contributor

@wozozo wozozo commented Apr 23, 2025

  • Added GitHub Actions workflow for Ruff linting/formatting and standardized string quotes to double quotes across the codebase.
  • Reformatted code for PEP 8 compliance, improved exception handling, and enhanced error messages.
  • Cleaned up imports, removed redundancies, and simplified expressions to improve code quality and maintainability.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new GitHub Actions workflow to run Ruff for linting and formatting, while also standardizing string quotes to double quotes and reformatting the codebase for PEP 8 compliance.

  • Introduces Ruff lint/format workflow via GitHub Actions.
  • Reformats code with double quotes and cleans up imports and expressions.

Reviewed Changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated no comments.

File Description
setup.py Removed the Python version check and reformatted quotes.
pyproject.toml Added Ruff configuration for target version, line length, etc.
payjp/, payjp/test/ Uniformly updated quotes and minor formatting changes.
.github/workflows/ruff.yml Added workflow to integrate Ruff in CI.
Files not reviewed (2)
  • requirements-dev.txt: Language not supported
  • tox.ini: Language not supported
Comments suppressed due to low confidence (1)

setup.py:2

  • The removal of the Python version warning might allow unsupported Python versions to be used. Please confirm that dropping support for Python versions below 3.8 is intentional.
if sys.version_info < (3, 8):

@wozozo wozozo merged commit 406e0f2 into master Apr 23, 2025
8 checks passed
@wozozo wozozo deleted the ruff branch April 23, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants