-
Notifications
You must be signed in to change notification settings - Fork 106
fix(tools)!: deps: remove glob, update peers #2958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Requires nodejs >= v22
🦋 Changeset detectedLatest commit: 8bf5e54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(tools)!: deps: remove glob, update peers"
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the dependency on the glob npm package by migrating to Node.js's built-in glob function from node:fs/promises, which requires Node.js >= v22. The PR also updates numerous peer dependencies to newer versions.
Key changes:
- Replaces
globpackage imports withnode:fs/promisesglob API across multiple files - Updates Node.js requirement to >= v22 in the changeset
- Updates 40+ peer dependency versions in package.json
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/pfe-tools/package.json | Updates peer dependencies to newer versions and implicitly removes glob dependency |
| tools/pfe-tools/dev-server/plugins/import-map-generator.ts | Migrates from glob package to node:fs/promises glob API with async iteration |
| tools/pfe-tools/custom-elements-manifest/lib/get-all-packages.ts | Migrates from glob package to node:fs globSync and implements custom hasMagic function |
| tools/pfe-tools/11ty/plugins/todos.cjs | Migrates from glob package to fs/promises glob with Array.fromAsync wrapper |
| tools/pfe-tools/11ty/plugins/custom-elements-manifest.cjs | Migrates from glob package to node:fs/promises glob with Array.fromAsync wrapper |
| package-lock.json | Updates lock file to reflect new peer dependency versions and their transitive dependencies |
| .changeset/short-numbers-double.md | Documents the breaking change requiring Node.js >= 22 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Requires nodejs >= v22