Skip to content

Conversation

@bennypowers
Copy link
Member

Requires nodejs >= v22

@bennypowers bennypowers requested a review from Copilot December 26, 2025 07:20
@changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2025

🦋 Changeset detected

Latest commit: 8bf5e54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-tools Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2025

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(tools)!: deps: remove glob, update peers"
}

@github-actions github-actions bot added the AT passed Automated testing has passed label Dec 26, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the dependency on the glob npm package by migrating to Node.js's built-in glob function from node:fs/promises, which requires Node.js >= v22. The PR also updates numerous peer dependencies to newer versions.

Key changes:

  • Replaces glob package imports with node:fs/promises glob API across multiple files
  • Updates Node.js requirement to >= v22 in the changeset
  • Updates 40+ peer dependency versions in package.json

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/pfe-tools/package.json Updates peer dependencies to newer versions and implicitly removes glob dependency
tools/pfe-tools/dev-server/plugins/import-map-generator.ts Migrates from glob package to node:fs/promises glob API with async iteration
tools/pfe-tools/custom-elements-manifest/lib/get-all-packages.ts Migrates from glob package to node:fs globSync and implements custom hasMagic function
tools/pfe-tools/11ty/plugins/todos.cjs Migrates from glob package to fs/promises glob with Array.fromAsync wrapper
tools/pfe-tools/11ty/plugins/custom-elements-manifest.cjs Migrates from glob package to node:fs/promises glob with Array.fromAsync wrapper
package-lock.json Updates lock file to reflect new peer dependency versions and their transitive dependencies
.changeset/short-numbers-double.md Documents the breaking change requiring Node.js >= 22

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bennypowers bennypowers changed the title fix(tools)!: remove dependency on glob fix(tools)!: deps: remove glob, update peers Dec 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit d611790
😎 Deploy Preview https://deploy-preview-2958--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 26, 2025

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 8bf5e54
🔍 Latest deploy log https://app.netlify.com/projects/patternfly-elements/deploys/694e3bdfc23e0000070457ab
😎 Deploy Preview https://deploy-preview-2958--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

SSR Test Run for f5bc171: Report

@github-actions
Copy link
Contributor

SSR Test Run for d611790: Report

@bennypowers bennypowers merged commit a4dee0c into main Dec 26, 2025
15 checks passed
@bennypowers bennypowers deleted the fix/tools/no-glob-dep branch December 26, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants