Open
Conversation
| import Accordion from './Accordion'; | ||
| import AccordionDetail from './AccordionDetail'; | ||
| import AccordionHeader from './AccordionHeader'; | ||
|
|
Owner
There was a problem hiding this comment.
https://github.com/patricklindev/pat-ui/blob/production/src/components/Dropdown/index.tsx
Combine Accordion Related component together
Collaborator
Author
There was a problem hiding this comment.
I have done this
| } | ||
|
|
||
| export const ControlledAccordion:React.FC = () => { | ||
| const [expanded, setExpanded] = React.useState<string | false >(false); |
| </Accordion> | ||
| </AccordionDetail> | ||
| </Accordion> | ||
| } |
Owner
There was a problem hiding this comment.
add Nested According example
|
|
||
| it('should render items', () => { | ||
| const headerSec = 'HelloFromHeader' | ||
| const detailSec = 'HelloFromDetail' |
Owner
There was a problem hiding this comment.
rename it for better understanding
| </AccordionDetail> | ||
| </Accordion>) | ||
| const activeDiv = document.querySelector('.accordion-container.active') | ||
| expect(activeDiv).toHaveClass('accordion-container active') |
| </AccordionDetail> | ||
| </Accordion>) | ||
| const headerEl = screen.queryByText(headerSec) as HTMLDivElement | ||
| fireEvent.click(headerEl) |
Collaborator
There was a problem hiding this comment.
Should be good. Accordion element is checked to see if it does not have the 'active' class before the click. Then, it is checked after the click to see if it has the 'active' class
|
|
||
| expect(Object.values(accordionHeaderDiv)).toHaveLength(3) | ||
| }) | ||
| // it('should open one at a time', () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://yuhan.atlassian.net/browse/PUI-7?atlOrigin=eyJpIjoiYTFmNmJiNGM2YTMwNGI5NDgzOTFjNTRiODYxZmMyMzgiLCJwIjoiaiJ9
Accordion component design, unit test and storybook.